Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bearby wallet integration #264

Closed
wants to merge 1 commit into from
Closed

Conversation

mazmassa
Copy link
Contributor

No description provided.

@mazmassa mazmassa changed the title add bearby wallet integration DO NOT MERGE! Draft - Add bearby wallet integration Sep 18, 2023
@mazmassa mazmassa changed the title DO NOT MERGE! Draft - Add bearby wallet integration DO NOT MERGE IT! Draft - Add bearby wallet integration Sep 18, 2023
@@ -33,13 +31,13 @@ export const U256_MAX = BigInt(
export const forwardBurnFees = {
fee: 0n,
coins: 100000n,
maxGas: 1000000n,
maxGas: 4294967295n,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ I need to check that first!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think you should change this.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's why I place an alert here. ;)

However, with 1000000n it just didn't work (was not working at least). So, in the received error that was the amount asked to fill.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it used to work because station set the maximum gas level itself.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Today I'm not 100% sure about that but it could explain why the gas amount was ok with station but not bearby

};

export const increaseAllowanceFee = {
fee: 0n,
coins: 1000n,
maxGas: 1000000n,
maxGas: 4294967295n,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ I need to check that first!

@mazmassa mazmassa force-pushed the add-bearby-integration branch 2 times, most recently from 12372ce to 9cc0bc5 Compare September 18, 2023 18:56
@peterjah
Copy link
Contributor

Default value or placeholder is missing!
image

@Thykof Thykof marked this pull request as draft November 18, 2023 00:32
@Thykof Thykof changed the title DO NOT MERGE IT! Draft - Add bearby wallet integration Add bearby wallet integration Nov 18, 2023
@Thykof Thykof self-assigned this Nov 18, 2023
@Thykof Thykof force-pushed the add-bearby-integration branch 4 times, most recently from 30df08a to 21b499c Compare November 21, 2023 14:13
@peterjah peterjah force-pushed the add-bearby-integration branch from 21b499c to 784d886 Compare November 24, 2023 10:36
src/pages/Index/Index.tsx Outdated Show resolved Hide resolved
.addString(CONTRACT_ADDRESS)
.addU256(amount)
.serialize(),
parameter: new Args().addString(CONTRACT_ADDRESS).addU256(amount),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe this is why the operations don't work with bearby

@Thykof Thykof force-pushed the add-bearby-integration branch from 784d886 to cc10bb6 Compare November 28, 2023 14:34
@Thykof Thykof marked this pull request as ready for review November 28, 2023 14:37
Copy link
Contributor

@Thykof Thykof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to fix: operation error when bridge redeem with bearby wallet

@Thykof Thykof marked this pull request as draft November 29, 2023 15:55
install missing dependencies

fix typo NetworkStoreState

cypress add support file

rename supportedTokens

preselect a wallet provider
@Thykof Thykof force-pushed the add-bearby-integration branch from cc10bb6 to 523a0b5 Compare November 29, 2023 15:56
@peterjah peterjah closed this Jan 29, 2024
@Thykof Thykof deleted the add-bearby-integration branch March 29, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants